Closed
Conversation
…e-have-a-previous-schema
JivusAyrus
requested changes
Sep 4, 2023
| isBreaking: c.hasBreakingChanges ?? false, | ||
| isComposable: c.isComposable ?? false, | ||
| proposedSubgraphSchemaSDL: c.proposedSubgraphSchemaSDL ?? undefined, | ||
| // TODO: Figure out why type fails |
Member
There was a problem hiding this comment.
Did you find out why this happens?
| @@ -0,0 +1,6 @@ | |||
| ALTER TABLE "schema_checks" ADD COLUMN "schema_version_id" uuid NOT NULL;--> statement-breakpoint | |||
Member
There was a problem hiding this comment.
migration to populate the schema_version_id to the already existing schema checks?
| isComposable: boolean; | ||
| isBreaking: boolean; | ||
| proposedSubgraphSchemaSDL?: string; | ||
| originalSchemaSDL: string; |
Member
There was a problem hiding this comment.
can you add a comment saying what the originalSchemSDL means
Contributor
|
Closing due to inactivity. |
jensneuse
added a commit
that referenced
this pull request
Apr 24, 2026
…18) - #9: buildExplicitMappings accumulates composite @openfed__is mappings instead of returning on the first composite, so alternative @key directives on the same field still emit their own EntityKeyMappingConfig - #10: nested auto-mapping runs the same extra-argument invalidation check as flat-key mappings via new shared helper invalidateAutoMappingWithExtraArgument - #11: add missing `version` argument to the negativeCacheTTL failure test - #18: buildCompositeIsMapping normalizes argInfo.isFieldValue before key lookup so "sku id" matches an "id sku" key Thread #8 (coderabbit: error on @queryCache interface return) investigated and refuted — rules 37 / 37b in entity-cache-mapping-rules.test.ts assert this case must succeed with no warning because concrete implementations carry @entityCache. Thread #17 (coderabbit: unwrap NonNull in typesMatchIncludingListShape) investigated and refuted — rule 15b, 40, 40b, 40c encode the opposite semantics: explicit @openfed__is is lenient about NonNull when named type matches, nested auto-mapping is strict. composition/CLAUDE.md lines 142-146 were stale and misled review tooling; corrected in this commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Diff checks in dark & light modes: